[Bug 197198] Review Request: ntop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198





------- Additional Comments From pertusus at free.fr  2006-08-27 19:50 EST -------
* Among the rpmling warning there is:
W: ntop devel-file-in-non-devel-package /usr/lib/libntop.so
W: ntop devel-file-in-non-devel-package /usr/lib/libmyrrd.so
W: ntop devel-file-in-non-devel-package /usr/lib/libntopreport.so

I think those files shouldn't be shipped.

* Seems like you removed too much in the plugins directory, 
there aren't plugins anymore...

I propose something along
for file in %{buildroot}/%{_libdir}/%{name}/plugins/*.so; do
  if test -L $file; then
     base=`basename $file .so`
     mv %{buildroot}/%{_libdir}/%{name}/plugins/$base-%{version}.so $file
  fi
done




The proper fix should be done upstream, by changing, for each 
plugin:
libicmpPlugin_la_LDFLAGS = -shared -release @PACKAGE_VERSION@ @DYN_FLAGS@
into
libicmpPlugin_la_LDFLAGS = -module -avoid-version @DYN_FLAGS@
Strangely, -shared doesn't seems to be a libtool option. It
is certainly unneeded.

* there are still bad perms, that should be fixed in %setup:

chmod -x docs/ntop-autotools.pdf *.c *.h plugins/*.c

* --enable-tcpwrap should be replaced by --with-tcpwrap

* you could add to the configue call: --disable-dependency-tracking

* there is still a dependency on logrotate missing

* some doc files are missing: README in source directory, and
in docs: 1STRUN.txt, KNOWN_BUGS, README, FAQ*, BUG_REPORT
some shouldn't be packaged (INSTALL, CONTENTS)

* during the first run with -t 5, I get:
Mon Aug 28 01:31:32 2006 [MSGID0026798] **WARNING** ASN: Unable to open file
'AS-list.txt'

Also ntop cannot be interrupted during that first run: hitting 
ctrl-C does nothing while ntop is prompting:

Please enter the password for the admin user: 

I can kill ntop from another console but then the first one
is broken

* there is still
lun 28 aoû 2006 01:36:52 CEST [MSGID0757670] **WARNING** Message is
'/usr/lib/ntop/plugins/libxmldumpPlugin.so: undefined symbol:
gdome_doc_documentElement'

Otherwise it seems to work.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.