[Bug 204162] Review Request: perl-Heap - Perl extension for keeping data partially sorted

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 28 16:20:53 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Heap - Perl extension for keeping data partially sorted


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204162


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From cweyl at alumni.drew.edu  2006-08-28 12:20 EST -------
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ source files match upstream:
 6934be7ffe351b3eea844d24a07ebc36  Heap-0.71.tar.gz
 6934be7ffe351b3eea844d24a07ebc36  Heap-0.71.tar.gz.srpm
+ latest version is being packaged.
+ BuildRequires are proper.
+ package builds in mock (5/x86_64).
+ rpmlint is silent.
+ final provides and requires are sane:
 ** perl-Heap-0.71-1.fc5.noarch.rpm
 == rpmlint
 == provides
 perl(Heap) = 0.71
 perl(Heap::Binary) = 0.71
 perl(Heap::Binomial) = 0.71
 perl(Heap::Elem) = 0.71
 perl(Heap::Elem::Num) = 0.71
 perl(Heap::Elem::NumRev) = 0.71
 perl(Heap::Elem::Ref) = 0.71
 perl(Heap::Elem::RefRev) = 0.71
 perl(Heap::Elem::Str) = 0.71
 perl(Heap::Elem::StrRev) = 0.71
 perl(Heap::Fibonacci) = 0.71
 perl-Heap = 0.71-1.fc5
 == requires
 perl(:MODULE_COMPAT_5.8.8)
 perl(AutoLoader)
 perl(Exporter)
 perl(Heap::Fibonacci)
 perl(strict)
 perl(vars)
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ %check is present and all tests pass
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list