[Bug 197649] Review Request: gnustep-make - GNUstep makefile package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnustep-make -  GNUstep makefile package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197649





------- Additional Comments From Axel.Thimm at ATrpms.net  2006-08-28 19:56 EST -------
Thanks for the review!

About 1.

> 1. package meets naming and packaging guidelines, however, I'd like to see some
> reasoning why /usr/libexec/gnustep is used instead of %{_libdir}/gnustep and,
> similarly, %{_datadir}/gnustep/Libraries instead of %{_libdir}/gnustep/Libraries

libexec is chosen because the parts placed in there are called by parts of
gnustep-make, e.g. which_lib. The choice about FHS'izing gnustep-make is a bit
arbitrary since upstream hasn't yet properly addressed this, but most parts are
derived from mail exchanges between gnustep-make authors and ogo authors.

datadir instead of libdir is chosen because there is nothing arch-dependent in
there.

About 4.

> 4. build root NOT correct, should be:
>       %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

This is the "preferred buildroot" which is not a must-buildroot. This issue was
brought up some time ago in the packaging group and consensus was mostly, that
if it works it passes.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.