[Bug 204250] Review Request: Ngspice - A mixed level/signal circuit simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Ngspice - A mixed level/signal circuit simulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204250





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-29 03:45 EST -------
Second review:

* rpmlint issue:
  - Well, will you check rpmlint issue before updating 
  srpm and spec file, please?

  This time mock build is okay (except for one problem),
  however:

E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/include/mif.h
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/xspice/evt/evtload.c
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/xspice/cm/cmexport.c
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/xspice/cm/cmmeters.c
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/xspice/mif/mif_inp2.c
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/include/enh.h
E: ngspice-debuginfo script-without-shellbang
/usr/src/debug/ng-spice-rework-17/src/xspice/cmpp/read_ifs.c
...... (continues) .......

  ... perhaps this is due to permission issue. Change permissions
  of \*.{c,h,y,l} to 0644.

E: ngspice-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/ng-spice-rework-17/src/xspice/cm/cmevt.c
   Perhaps cmevt.c has Windows-like end-of-line encoding.
   Try:
   %{__sed} -i -e 's|\r||' <file>
   to get rid of this error.

* BuildRequires:
   - compat-gcc-32-gc77 is unnecessary.
   This package does not use g77 when rebuilt. I could succeed in
   rebuilding without this package.
   Also, FC-6 devel doesn't have compat-gcc-32-g77 .
   - xorg-x11-proto-devel is required by libX11-devel.
   - libXmu-devel is required by libXaw-devel .
   - libXt-devel is required by libXaw-devel.

   - flex, bison, libtool
   Check if these packages are really needed. For me, mock
   build succeeds without these and the rebuilt packages seems
   functionally okay for the test case in the comment #2.

* Exclusion of Static Libraries:
  - Well, %{_libdir}/ng-spice-rework/libbsim4.a seems unnecessary.
  So, remove this on %install stage by rm command and get rid of
  the use of %exclude.
  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.