[Bug 204263] Review Request: geda-symbols - Electronic symbols for gEDA

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-symbols - Electronic symbols for gEDA


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-29 08:37 EST -------
Created an attachment (id=135122)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135122&action=view)
file lists of geda-symbols

First review.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

  * Timestamps 
    - Well, it seems this package has many text files. So 
    preserving timestamps is very desirable. 
    Try to change "make install" option so that (perhaps) 
    most files can keep timestamps. In xscreensaver case (I maintain
    xscreensaver), I use 

	  make INSTALL="install -p" install

    Check if this package accepts such options, or, if not,
    change Makefile so that install command is used with -p option.

  * File and Directory Ownership

  - %{_datadir}/gEDA/scheme
    %{gedadocdir}/man

    I don't know why these empty directories needs to be 
    included in this package. 

    Usually if other packages install
    some files in these directories, it is the package
    which should own these directories, not this package. However,
    * if you aim to sumbit other packages and
    * the packages install some files in that directories and
    * the packages surely requires this package,
    these directories can be owned by this package.

    Let me know your opinion about these directories.

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   okay.

3. Other things I have noticed :


  - Consider if /usr/share/gEDA/docs can be moved
    to usual document files' location, i.e.
    /usr/share/doc/geda-symbols-%{version}

  - I will attach the file entry of geda-symbols rebuilt in
    mock. Please check if all files you want to install in
    this package are correctly packaged.

---------------------
BTW, could you review my package (bug 204461) ? Again, this package
is aimed for Japanese users......


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.