[Bug 204250] Review Request: Ngspice - A mixed level/signal circuit simulator
bugzilla at redhat.com
bugzilla at redhat.com
Wed Aug 30 05:25:48 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Ngspice - A mixed level/signal circuit simulator
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204250
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-08-30 01:25 EST -------
Created an attachment (id=135186)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135186&action=view)
Mock build log of ngspice-17-3
Okay. 3rd review.
1. From http://fedoraproject.org/wiki/Packaging/Guidelines
= rpmlint became silent.
* Compiler flags
- I checked this again, however, it is not yet okay.
My mock build log says:
+ /usr/bin/make
/usr/bin/make all-recursive
make[1]: Entering directory `/builddir/build/BUILD/ng-spice-rework-17'
Making all in xgraph
make[2]: Entering directory `/builddir/build/BUILD/ng-spice-rework-17/xgraph'
/usr/bin/make all-am
make[3]: Entering directory `/builddir/build/BUILD/ng-spice-rework-17/xgraph'
if gcc -DHAVE_CONFIG_H -I. -I. -I. -g -MT xgraph.o -MD -MP -MF
".deps/xgraph.Tpo" -c -o xgraph.o xgraph.c; \
then mv -f ".deps/xgraph.Tpo" ".deps/xgraph.Po"; else rm -f
".deps/xgraph.Tpo"; exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I. -g -MT xgX.o -MD -MP -MF
".deps/xgX.Tpo" -c -o xgX.o xgX.c; \
then mv -f ".deps/xgX.Tpo" ".deps/xgX.Po"; else rm -f ".deps/xgX.Tpo";
exit 1; fi
.......
So the compilation in ng-spice-rework-17/xgraph do not accept
Fedora specific compilation flags.
Check and change Makefile(.in) in ng-spice-rework-17/xgraph so that
sources are correctly compiled with Fedora specific compilation
flags.
2. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
= Nothing.
3. The other things I have noticed :
= Nothing.
Please see the build log attached in mock.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list