[Bug 204423] Review Request: libstroke - A stroke interface library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libstroke - A stroke interface library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-30 16:03 EST -------
(In reply to comment #10)
> Updated:
> Spec URL: http://chitlesh.funpic.de/rpm/libstroke.spec
> SRPM URL: http://chitlesh.funpic.de/rpm/libstroke-0.5.1-10.src.rpm

Well, not yet okay.

rpm -qlp *0.5.1*rpm | sort says

/usr/share/stroke/tests
/usr/share/stroke/tests/gnome_stroke_test
/usr/share/stroke/tests/gnome_stroke_test
/usr/share/stroke/tests/stroke_test
/usr/share/stroke/tests/stroke_test.tcl
/usr/src/debug/libstroke-0.5.1

... /usr/share/stroke/tests/gnome_stroke_test is owned by
    libstroke-devel and libgstroke-devel

and... from this package: there is a case that
only libgstroke and libgstroke-devel and libstroke are installed:

in that case the directory %{_datadir}/stroke/tests/ is not owned
by any packages. This is not correct.

So:
%files -n %{name}
%defattr(-,root,root)
%doc README COPYRIGHT ChangeLog NEWS AUTHORS TODO CREDITS
%dir %{_datadir}/stroke/
%dir %{_datadir}/stroke/tests/
%{_libdir}/libstroke.so.*

%files -n %{name}-devel
%defattr(-,root,root)
%doc doc/standard_strokes*
%{_datadir}/stroke/tests/stroke_test*
%{_datadir}/aclocal/libstroke.m4
%{_libdir}/libstroke.so
%{_includedir}/stroke.h

%files -n libgstroke
%defattr(-,root,root)
%doc README COPYRIGHT ChangeLog NEWS AUTHORS TODO CREDITS
%{_libdir}/libgstroke.so.*

%files -n libgstroke-devel
%defattr(-,root,root)
%doc README.libgstroke
%{_datadir}/stroke/tests/gnome_stroke_test
%{_datadir}/aclocal/libgstroke.m4
%{_libdir}/libgstroke.so
%{_includedir}/gstroke.h

%files -n javastroke
%defattr(-,root,root)
%doc javastroke/README
%{_datadir}/stroke/java/

is correct (I think. check it).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.