[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561





------- Additional Comments From kevin at tummy.com  2006-08-30 22:49 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
eabc78b67018efdfea68ae9b9d545e80  pyspf-1.7.tar.gz
eabc78b67018efdfea68ae9b9d545e80  pyspf-1.7.tar.gz.1
OK - Package compiles and builds on at least one arch.
See below - BuildRequires correct
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
SHOULD Items:
See below - Should include License or ask upstream to include it.
OK - Should build in mock.

Issues:

1. There seems to be some confusion on the license on this package...
You have 'Python License' in the spec, but the package lists
'Python Software Foundation License' in several places. Most confusingly,
the spfquery.py file says it's released under the GPL:

PKG-INFO:License: Python Software Foundation License
PKG-INFO:Classifier: License :: OSI Approved :: Python Software Foundation 
License
README:License: Python Software Foundation License
setup.py:      license='Python Software Foundation License',
setup.py:       'License :: OSI Approved :: Python Software Foundation License',
spfquery.py:# This code is under the GNU General Public License.  See COPYING 
for details.

2. rpmlint has some output:

W: python-pyspf summary-ended-with-dot Python module and programs for SPF 
(Sender Policy Framework).

suggest: remove the . at the end of summary.

W: python-pyspf incoherent-version-in-changelog 1.7-1 1.7-2.fc6

suggest: add changelog for -2 release.

W: python-pyspf invalid-license Python License

suggestion: see issue 1.

E: python-pyspf non-executable-script /usr/lib/python2.4/site-packages/spf.py 
0644
                                                                                          
spf.py has a #! for python, so it should either be 755 or (more likely) have
the top line simply removed so it can be used as a python module instead of a 
script.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.