[Bug 215883] Review Request: idioskopos - C++ Introspection Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idioskopos - C++ Introspection Library
Alias: idioskopos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215883





------- Additional Comments From rvinyard at cs.nmsu.edu  2006-12-01 11:34 EST -------
> A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
> * Licensing

Got that fixed. I copied the .pc.in from another project (that I have under the
GPL), and missed changing that one.

> * BuildRequires:
>   - Is m4 required?

Yes. My configure script needs m4 (it's used to autobuild the Fedora and SuSE
.spec files from spec.m4), and m4 isn't on the exceptions list:
     http://fedoraproject.org/wiki/Extras/FullExceptionList

> * Timestamps

I hadn't even noticed that. I agree, preserving the timestamps is nice!

Changed:
%{__make} DESTDIR=%{buildroot} install

To:
%{__make} DESTDIR=%{buildroot} INSTALL="%{__install} -p" install

> C. Other things I have noticed:

Yes, that is much better.

Thanks for all your help.

A new spec and release are at:

Spec URL: http://miskatonic.cs.nmsu.edu/pub/idioskopos.spec
SRPM URL: http://miskatonic.cs.nmsu.edu/pub/idioskopos-0.3.2-1.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.