[Bug 218022] Review Request: clamsmtp - SMTP filter daemon for anti-virus checking using ClamAV

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 1 16:38:04 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clamsmtp - SMTP filter daemon for anti-virus checking using ClamAV


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218022





------- Additional Comments From matthias at rpmforge.net  2006-12-01 11:38 EST -------
Thanks a lot for all these comments. Although you can't currently do any formal
review or approval, this does help a lot the process ;-)

New spec file : http://ftp.es6.freshrpms.net/tmp/extras/clamsmtp.spec
New srpm : http://ftp.es6.freshrpms.net/tmp/extras/clamsmtp-1.8-2.src.rpm

- I've externalized all of the clamd integration files.
- I've added -q to %setup.
- I've replaced %makeinstall with the DESTDIR method (and it works)

> W: clamsmtp no-reload-entry /etc/rc.d/init.d/clamsmtpd
> init.d/clamsmtpd claims it can do start, stop, restart, status, condrestart.
> However only start, stop and restart are implemented

The script can't do "reload" indeed, but all advertised functions are there.

About the inconsisten naming, I don't think it is. There are two quite different
things in this package : The clamsmtpd daemon itself, which if from the upstream
clamsmtp project (I would have named the project "clamsmtpd", myself...), and
then all the "glue" I add in order to not have to configure anything manually.
This "glue" is what is called "clamd.smtp" since this is how Enrico packaged
ClamAV : You can run your own instance called "clamd.whatever", and here it's
really useful since clamsmtp can run its own instance, thus be completely
standalone and working out of the box.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list