[Bug 203288] Review Request: devilspie

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: devilspie


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203288


fedora at christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From fedora at christoph-wickert.de  2006-12-01 20:38 EST -------
REVIEW for 
6c989b45ab19ff212d5a7d55d624543d  devilspie-0.19-1.fc6.src.rpm

MUST Items:
OK - rpmlint quite on all packages
OK - package meets naming guidelines
OK - spec file meets naming guidelines
OK - package meets package guidelines
OK - license open-source compatible (GPL)
OK - license in specfile matches actual license
OK - license included in %doc
OK - spec file in American English
OK - spec file is legible
OK - source in SRPM matches upstream source 
  (md5 35f555000b426e21384ab282c64c6975)
OK - package builds on i386
OK - all build dependencies listed BuildRequires

FIX - BuildRequires: gob2 is not needed AFAICS. Maybe it was needed in previous
versions, but this source contains no gob files.

MINOR - you better use "perl(XML::Parser)" instead of "perl-XML-Parser" for the
BuildRequires:.

OK - none of the exceptions of packaging guidelines in BuildRequires
OK - locales handled correctly with %find_lang
OK - no shared libs to worry about
OK - package is not relocatable
OK - package owns all directories that it creates
OK - no duplicate files in %files section
OK - permissions and %defattr correct 
OK - clean section with "rm -rf $RPM_BUILD_ROOT" present
OK - macro usage consistent
OK - code, not content
OK - no large docs
OK - docs don't affect runtime

FIX - ChangeLog is not in the package, please add it to %doc.

OK - no headers or static libs
OK - no pkgconfig files
OK - no libtool archives
OK - no need for a devilspie.desktop
OK - package doesn't own files/directories owned by other packages

SHOULD items:
OK - package builds in mock (Core 5, 6 and devel on i386)
OK - package functions as described
OK - package uses disttag

This package is APPROVED but you need to fix the issues mentioned above before
you build it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.