[Bug 218172] Review Request: gnome-chemistry-utils - A set of chemical utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-chemistry-utils - A set of chemical utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218172





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-02 13:17 EST -------
Well, interesting package.
>From a quick view:

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Requires:
  - for -mozplugin package:
    Why does this require pkgconfig?

  - for -devel package:
    Please check /usr/lib/pkgconfig/gcu.pc
----------------------------------------------------------
Requires: libglade-2.0 libgnomeui-2.0 libgnomeprintui-2.2 gtkglext-1.0 openbabel-2.0
----------------------------------------------------------
    This means that this (-devel) package requires:
---------------------------------------------------------
(libglade2-devel : required by libgnomeui-devel so this is redundant).
libgnomeui-devel
libgnomeprintui22-devel
gtkglext-devel
openbabel-devel
---------------------------------------------------------
   Otherwise we get a error like:
---------------------------------------------------------
[tasaka1 at localhost ~]$ pkg-config --cflags gcu
Package openbabel-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `openbabel-2.0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'openbabel-2.0', required by 'Gnome Chemistry Utils', not found
---------------------------------------------------------

* Documentation
  - Files under docs/reference/html are rather large in total and
    most (or all?) files are automatically generated by doxygen.
    I think these files should be in -devel package.

* Desktop files
  - Please use 'desktop-file-install' and add 'fedora' as vendor tag (then add
    'desktop-file-utils' to BuildRequires)
  - Would you ask upstream to include icons for GUI desktop?

* Timestamps
  - Well, -devel package contains a lot of header files so
  keeping timestamps is highly preferable as
  * it shows if vendor (like you) have modified the original
    files
  * it shows when the files are created

  So keep timestamps, at least for header files.
  Usually,
--------------------------------------------------------
make INSTALL="install -p" install
--------------------------------------------------------
  plays the trick.

  - /usr/bin/install -c -m 644
    Use "%{__install} -c -p -m 644" to keep timestamps, use
    macros.

B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   (Okay)

C. Other things I have noticed:
*  test -z $RPM_BUILD_ROOT%{_datadir}/mime/packages ||
   - This is redundant because it is apparently not zero length.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.