[Bug 218367] Review Request: compat-guile - Guile compatibility package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-guile - Guile compatibility package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218367





------- Additional Comments From cgoorah at yahoo.com.au  2006-12-07 14:30 EST -------
#001 Parallel builds
%{?_smp_mflags} missing on make

#002 typo
Line 83
# Ouch! guile forgets to set it's onw shared lib path to use shared uninstalled

>>>> own

#003 cleanups ?
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

$RPM_BUILD_ROOT isn't defined up in the spec file ?
Is it useful ?

#004: missing url tag

#005: macro-in-%changelog
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog file
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog post
W: compat-guile macro-in-%changelog postun
W: compat-guile macro-in-%changelog attr
W: compat-guile macro-in-%changelog post
W: compat-guile macro-in-%changelog description
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog postun
W: compat-guile macro-in-%changelog PACKAGE_VERSION
W: compat-guile macro-in-%changelog attr

add a % more in front for those macros 

#007 mixed-use-of-spaces-and-tabs
W: compat-guile mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 86)

Other Rpmlints issues:
$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/compat-libguile-1.6.7-1.i386.rpm
 dangling-relative-symlink
W: compat-libguile dangling-relative-symlink /usr/share/guile/slib ../../share/slib
E: compat-libguile non-standard-executable-perm /usr/share/guile/1.6/scripts/c2x
0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/scan-md-module 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/slurp 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/make-module-catalog 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/PROGRAM2 0555

$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/compat-libguile-devel-1.6.7-1.i386.rpm
W: compat-libguile-devel no-dependency-on compat-libguile

Fix those, I'll approve it, However it builds successfully under mock.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.