[Bug 196393] Review Request: svrcore

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: svrcore
Alias: svrcore

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393





------- Additional Comments From toshio at tiki-lounge.com  2006-12-08 12:40 EST -------
New srpm:
http://www.tiki-lounge.com/~toshio/fedora/svrcore-4.0.2.02-0.src.rpm

I've gone through the #ifdefs now and made a few minor changes.  I think this
tarball is good to go as far as replacing coreconf with autotools.  It will need
some tweaking from your end (documentation, runtime testing, etc) but is largely
complete.

Changes:
* configure.ac: We don't have any fallbacks in code for missing string.h,
termios.h, or unistd.h so Have configure error if any of those are missing.

* ntgetpin.c, user.c: Code was using both #ifdef WIN32 and #ifdef _WIN32. 
Changed all to the _WIN32 form.

* user.c: Instead of checking if we're building on XP_UNIX, check that we aren't
building on _WIN32.  This matches with code later in the file that uses the
functions define here if we are not on _WIN32.


I'll post this to the upstream bugzilla as well.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.