[Bug 218907] Review Request: search4files - A handy file search tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: search4files - A handy file search tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218907


fedora at christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From fedora at christoph-wickert.de  2006-12-09 17:37 EST -------
REVIEW for 
f7bdb6dfd5f9fb3350954bb20c11381b  search4files-0.1c-1.src.rpm

OK - rpmlint gives a 'configure-without-libdir-spec' error on the srpm:
     ./configure doesn't take --configure. no libs, so this doesn't matter.
OK - package named according to the package naming guidelines
OK - specfile name matches package name
OK - package meets packaging guidelines
OK - license is open-source compatible (GPL)
OK - license field in spec matches actual license
OK - license included in source and correctly installed in %doc
OK - spec is in American English
OK - spec is legible and very well documented
OK - source in srpm matches upstream by md5
     d568697071bf93fad090a77e9d78f4d1
OK - package compiles and build into noarch rpm on core 6 i386
OK - BuildRequires are sane
OK - no locales to worry about
OK - no shared libs to worry about
OK - package is not relocatable
OK - package owns all directories it creates
OK - no duplicates in %files
OK - file permissions and %defattr are correct
OK - valid clean section present
OK - macro usage consistent
OK - code, not content
OK - no header files, static libs or *.pc files
OK - no libtool archives
OK - fedora-search4files.desktop is correctly installed with desktop-file-install
OK - package doesn't own directories already owned by other files
OK - package builds in mock (devel)
OK - package works fine

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.