[Bug 219025] Review Request: ntop - A network traffic probe similar to the UNIX top command

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025





------- Additional Comments From bjohnson at symetrix.com  2006-12-11 03:36 EST -------
> Well, another:
> * Timestamps:
>   For cp or install, please use "cp -p" or "install -p" to keep 
>   timestamps
>   http://fedoraproject.org/wiki/Packaging/Guidelines

Fixed.

> * Source0
>   Please specify URL.

Fixed.

> * # strip off version number from plugin .so files
>   Why is this needed?

This was suggested by Patrice here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198#c37.  This makes
sense to me as dl'opened modules aren't versioned.


> * applying patch
>   I prefer adding some suffix to original files. i.e. for example:
> ------------------------------------
> %patch0 -p1 -b .plugins
> %patch1 -p1 -b .conf
> -------------------------------------

Fixed.

> * Requires:       fedora-usermgmt
>   This is for scriplets?  If so, please write:
>   Requires(pre): /usr/sbin/fedora-groupadd
>   and so on and not write "Requires:  fedora-usermgmt", however,
>   please consider to use normal %{_sbindir}/groupadd and so on.
>   ref: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

Looking into this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.