[Bug 219164] Review Request: fontypython - TTF font manager

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 12 05:27:03 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fontypython - TTF font manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219164


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-12 00:27 EST -------
Well,

* please check if the dependency a package (python-imaging, ...) should
  be BuildRequires or Requires or _both_ .
  From setup.py, wxPython, python-imaging is needed for BuildRequires,
  surely. And, as I noted in comment #1, these dependency should also
  required by "Requires".
  Note that python-related dependency is currently not checked
  automatically by rpmbuild and we have to check these manually.

  Currently I get the following error:
---------------------------------------------
[tasaka1 at localhost ~]$ fp
Neither wxgui nor qtgui interfaces could be found. Please consult the help.
---------------------------------------------

* Is rpmdevtools required for BuildRequires?

* for desktop files:
  Category Application is deprecated and this is warned by
  desktop-file-utils >= 0.11. Please remove this.

* rpmlint complains about description-line-too-long.
  (rpmlint command is in "rpmlint" rpm in Fedora Extras)
  This means:
-------------------------------------------------
[tasaka1 at localhost SRPMS]$ rpmlint -I description-line-too-long
description-line-too-long :
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
--------------------------------------------------

* for src.rpm:
---------------------------------------------------
W: fontypython strange-permission fontypython.desktop 0600
W: fontypython strange-permission fontypython.spec 0600
---------------------------------------------------
  Please change the permisson to 0644.

(In reply to comment #4)
> I will contact the author regarding renaming /usr/bin/fp - I believe I'll have
> to edit setup.py in order to make that change.
I think
------------------------------------
mv ${RPM_BUILD_ROOT}%{_bindir}/fp ${RPM_BUILD_ROOT}%{_bindir}/fontypython
------------------------------------
meet the demand.

  For mock problem on FC-devel, python-imaging is updated to
  python-imaging-1.1.5-7.fc7 (this is in queue and not published yet)
  and I rebuilt wxPython locally so I can check this by mockbuild.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list