[Bug 218258] Review Request: audacious-docklet - a docklet plugin for Audacious

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-docklet - a docklet plugin for Audacious


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218258





------- Additional Comments From fedora at christoph-wickert.de  2006-12-12 17:18 EST -------
(In reply to comment #4)
> Thank you so much for your carefully review. This is my first time...

No problem, you are welcome.

> I update the spec file as required.
> Spec URL: <http://yufanyufan.googlepages.com/audacious-docklet.spec>
> SRPM URL: <http://yufanyufan.googlepages.com/audacious-docklet-0.1.1.src.rpm>

I'm getting a 404 error on these.

> However, After I change Release tag to "1%{?dist}", there's no "fc6" in the
> src.rpm. Is that correct?

Yes, but the buildsys will resolve it to fc5/6/7. You could add something like

 %distname fc
 %distversion %(rpm -qf --qf='%{VERSION}' /etc/redhat-release)
 %dist    .%{distname}%{distversion}

to your ~/.rpmmacros to also have the disttag for your local builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.