[Bug 217197] Review Request: MyBashBurn 1.0-1 - burn data and songs.

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 13 04:48:38 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn 1.0-1 - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





------- Additional Comments From wilmer at fedoraproject.org  2006-12-12 23:48 EST -------
(In reply to comment #24)
> > E: mybashburn world-writable /etc/mybashburnrc 0666
> > ---> Note that this is good and is necessary for the package,
> >  see comment #3
> 
> Are you kidding? Files in /etc must not be writable by ordinary
> users. The software is flawed, if there is no implementation of
> user-local configuration files in $HOME.
> 

Yes, i'm sure, this should be ignored.

> > %{buildroot}/usr/lib/debug
> Then your RPM config or installation is broken. You don't need to
> create that directory.

Yes, fixed.

> You include the directory /usr/bin which is wrong, since it belongs into
> the core "filesystem" package already.

Fixed.

All other rpmlint E: have been solved:
1) Fixed DOS/Windows-like (CRLF) end-of-line encoding with %%{__sed} tag.
2) Replaced %%{_bindir}/* tag of %%files section by %%{_bindir}/files.
3) Cleanup in %%install section.
4) Replaced %%config(noreplace) instead %%config.

Updated to 1.0-2 -- package at:
http://www.fedora-ve.org/mybashburn/downloads/mybashburn.spec
SRPM URL:
http://www.fedora-ve.org/mybashburn/downloads/mybashburn-1.0-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list