[Bug 216103] Review Request: python-twisted-names - A Twisted DNS implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-names - A Twisted DNS implementation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216103


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-12-13 22:52 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
5aa672d0e26718466351351e7bfcf22a  TwistedNames-0.3.0.tar.bz2
5aa672d0e26718466351351e7bfcf22a  TwistedNames-0.3.0.tar.bz2.1

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

See below - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output. 
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
x86_64/i386 - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Why the
%{?!python:%define python python}
macro? It just means you have "%{python}" instead of "python" in several places.
How is that a win?

2. You should include the shipped LICENSE file as a doc.

3. For devel (python 2.5) you need to add:
BuildRequires: python-devel

4. rpmlint says:
E: python-twisted-names no-binary

Shouldn't this package be noarch?

W: python-twisted-names doc-file-dependency
/usr/share/doc/python-twisted-names-0.3.0/examples/dns-service.py /usr/bin/python
W: python-twisted-names doc-file-dependency
/usr/share/doc/python-twisted-names-0.3.0/examples/gethostbyname.py /usr/bin/env

Perhaps make those mode 644 ? 444?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.