[Bug 219025] Review Request: ntop - A network traffic probe similar to the UNIX top command

Thu Dec 14 14:59:08 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025

------- Additional Comments From pertusus at free.fr  2006-12-14 09:59 EST -------
There is a missing BR on net-snmp-devel. After net-snmp-devel is 
installed, build fails with:

gcc -shared  .libs/libsnmpPlugin_la-snmpPlugin.o  -L/lib -lgdome -lglib-2.0
-lxml2 -L/usr/local/lib -L/usr/lib -lne
tsnmpmibs -lnetsnmpagent -lnetsnmphelpers -lnetsnmp -lsensors -L/usr/lib/lib
/usr/lib/perl5/5.8.8/i386-linux-thread
-multi/auto/DynaLoader/DynaLoader.a
-L/usr/lib/perl5/5.8.8/i386-linux-thread-multi/CORE -lperl -lresolv -lnsl -ldl 
-lm -lutil -lpthread -lcrypt -lc -lssl -lcrypto -lpcap -lgdbm -lgd -lpng -lz
-lwrap  -m32 -march=i386 -mtune=generi
c -Wl,-E -Wl,-rpath -Wl,/usr/lib/perl5/5.8.8/i386-linux-thread-multi/CORE
-Wl,-soname -Wl,libsnmpPlugin-3.2.so -o .
libs/libsnmpPlugin-3.2.so
/usr/bin/ld: cannot find -lsensors
collect2: ld returned 1 exit status
make[3]: *** [libsnmpPlugin.la] Error 1

Before it fails, there is a big warning:
*** Warning: Linking the shared library libsnmpPlugin.la against the
*** static library
/usr/lib/perl5/5.8.8/i386-linux-thread-multi/auto/DynaLoader/DynaLoader.a is not
portable!

Some warnings that may be worrisome:

address.c: In function 'ipaddr2str':
address.c:516: warning: 'key_data.dptr' may be used uninitialized in this function
address.c:516: warning: 'key_data.dsize' may be used uninitialized in this function

fcUtils.c: In function 'processFcNSCacheFile':
fcUtils.c:565: warning: format '%02hx' expects type 'short unsigned int *', but
argument 3 has type 'u_int32_t *'
fcUtils.c:565: warning: format '%02hx' expects type 'short unsigned int *', but
argument 4 has type 'u_int32_t *'
fcUtils.c:565: warning: format '%02hx' expects type 'short unsigned int *', but
argument 5 has type 'u_int32_t *'

plugin.c: In function 'loadPlugins':
plugin.c:54: warning: 'prev' may be used uninitialized in this function

pbuf.c: In function 'processPacket':
pbuf.c:3153: warning: pointer targets in passing argument 2 of
'__builtin___strncpy_chk' differ in signedness
pbuf.c:3153: warning: pointer targets in passing argument 2 of '__strncpy_ichk'
differ in signedness

pbuf.c: In function 'processIpPkt':
pbuf.c:951: warning: 'off' may be used uninitialized in this function
pbuf.c:943: warning: 'snapend' may be used uninitialized in this function
pbuf.c:942: warning: 'cp' may be used uninitialized in this function
pbuf.c:944: warning: 'icmp6len' may be used uninitialized in this function

sessions.c: In function 'handleSession':
sessions.c:2550: warning: suggest parentheses around && within ||
sessions.c:2552: warning: suggest parentheses around && within ||

util.c: In function 'createThread':
util.c:1670: warning: format '%lu' expects type 'long unsigned int', but
argument 5 has type 'pthread_t *'
util.c: In function '_killThread':
util.c:1688: warning: format '%lu' expects type 'long unsigned int', but
argument 5 has type 'pthread_t *'
util.c: In function '_joinThread':
util.c:1708: warning: format '%lu' expects type 'long unsigned int', but
argument 5 has type 'pthread_t *'
util.c: In function '_accessMutex':
util.c:1796: warning: format '%s' expects type 'char *', but argument 7 has type
'void *'
util.c:1796: warning: format '%d' expects type 'int', but argument 8 has type
'char *'
util.c:1796: warning: too many arguments for format
util.c: In function '_tryLockMutex':
util.c:1870: warning: format '%s' expects type 'char *', but argument 7 has type
'void *'
util.c:1870: warning: format '%d' expects type 'int', but argument 8 has type
'char *'
util.c:1870: warning: too many arguments for format
util.c: In function '_releaseMutex':
util.c:1957: warning: format '%p' expects type 'void *', but argument 10 has
type 'pid_t'

util.c: In function 'pathSanityCheck':
util.c:3020: warning: array subscript has type 'char'
util.c: In function 'fileSanityCheck':
util.c:3093: warning: array subscript has type 'char'
util.c: In function 'ipSanityCheck':
util.c:3149: warning: array subscript has type 'char'

util.c: In function '_ntopSleepMSWhileSameState':
util.c:3950: warning: format '%u' expects type 'unsigned int', but argument 5
has type 'long unsigned int'
util.c:3968: warning: format '%d' expects type 'int', but argument 5 has type
'__time_t'
util.c:3968: warning: format '%d' expects type 'int', but argument 6 has type
'long int'
util.c: In function 'i18n_xvert_locale2common':
util.c:4252: warning: passing argument 1 of 'ntop_safestrdup' discards
qualifiers from pointer target type
util.c: In function 'i18n_xvert_acceptlanguage2common':
util.c:4277: warning: passing argument 1 of 'ntop_safestrdup' discards
qualifiers from pointer target type

util.c: In function 'convertNtopVersionToNumber':
util.c:5050: warning: format '%1[a-z' expects type 'char *', but argument 5 has
type 'unsigned char (*)[4]'

util.c: In function 'computeIdx':
util.c:266: warning: 'idx' may be used uninitialized in this function
util.c: In function 'computeTransId':
util.c:296: warning: 'transactionId' may be used uninitialized in this function
util.c: In function 'mkdir_p':
util.c:6544: warning: 'rc' may be used uninitialized in this function

traffic.c: In function 'matrixHostHash':
traffic.c:567: warning: 'hash' is used uninitialized in this function

graph.c: In function 'drawVsanStatsBytesDistribution':
graph.c:2393: warning: value computed is not used
graph.c: In function 'drawVsanStatsPktsDistribution':
graph.c:2476: warning: value computed is not used

http.c: In function '_sendStringLen':
http.c:1035: warning: type defaults to 'int' in declaration of 'econnresetcount'
http.c:1047: warning: too few arguments for format

fcReport.c: In function 'drawVsanStatsGraph':
fcReport.c:4639: warning: value computed is not used
fcReport.c: In function 'printFcTrafficSummary':
fcReport.c:4706: warning: value computed is not used
fcReport.c: In function 'makeFcHostLink':
fcReport.c:39: warning: 'linkStr' may be used uninitialized in this function

webInterface.c: In function 'initSocket':
webInterface.c:8180: warning: 'ai' may be used uninitialized in this function
webInterface.c: In function 'printNtopConfigInfoData':
webInterface.c:7089: warning: 'pT' may be used uninitialized in this function
webInterface.c:7089: warning: 'pM' may be used uninitialized in this function
webInterface.c:7087: warning: 'qT' may be used uninitialized in this function
webInterface.c:7087: warning: 'qM' may be used uninitialized in this function

ssl.c: In function 'term_ssl_connection':
ssl.c:307: warning: 'return' with no value, in function returning non-void
ssl.c:305: warning: 'rc' may be used uninitialized in this function

rrdPlugin.c: In function 'graphCounter':
rrdPlugin.c:567: warning: statement with no effect
rrdPlugin.c: In function 'netflowSummary':
rrdPlugin.c:707: warning: statement with no effect
rrdPlugin.c: In function 'graphSummary':
rrdPlugin.c:971: warning: statement with no effect

rrdPlugin.c: In function 'updateRRD':
rrdPlugin.c:1242: warning: statement with no effect
rrdPlugin.c:1298: warning: statement with no effect
rrdPlugin.c:1322: warning: format '%d' expects type 'int', but argument 5 has
type 'time_t'
rrdPlugin.c:1322: warning: format '%d' expects type 'int', but argument 7 has
type 'time_t'
rrdPlugin.c:1322: warning: format '%d' expects type 'int', but argument 9 has
type 'time_t'
rrdPlugin.c:1329: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:1329: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:1329: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:1329: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:1329: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:1329: warning: statement with no effect
rrdPlugin.c: In function 'rrdUpdateIPHostStats':
rrdPlugin.c:2835: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2835: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2835: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2835: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2835: warning: statement with no effect
rrdPlugin.c:2920: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2920: warning: left-hand operand of comma expression has no effect
rrdPlugin.c:2920: warning: statement with no effect
.... many other similar

rrdPlugin.c: In function 'rrdTrafficThreadLoop':
rrdPlugin.c:3081: warning: control reaches end of non-void function
rrdPlugin.c: In function 'handleRRDHTTPrequest':
rrdPlugin.c:384: warning: 'total' may be used uninitialized in this function

snmpPlugin.c: In function 'createAnswer':
snmpPlugin.c:739: warning: format '%d' expects type 'int', but argument 5 has
type 'oid'

snmpPlugin.c: In function 'processRequest':
snmpPlugin.c:833: warning: pointer targets in assignment differ in signedness

snmpPlugin.c: In function 'processRequest':
snmpPlugin.c:788: warning: 'size' may be used uninitialized in this function
snmpPlugin.c:787: warning: 'cp' may be used uninitialized in this function 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.