[Bug 220284] Review Request: bcfg2 - Configuration management client and server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bcfg2 - Configuration management client and server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220284





------- Additional Comments From jeff at ocjtech.us  2006-12-20 10:33 EST -------
(In reply to comment #2)
>
> W: bcfg2 invalid-license BCFG Public License
> W: bcfg2-server invalid-license BCFG Public License

We're (Axel and I) working with the upstream on this issue.

> E: bcfg2 wrong-line-in-lsb-tag #                    installs configuration files
> served by bcfg2-server
> E: bcfg2 wrong-line-in-lsb-tag #                    This is a client that
> installs the server provided
> E: bcfg2 wrong-line-in-lsb-tag #                    Configuration.

> E: bcfg2-server wrong-line-in-lsb-tag #                    installs
> configuration files served by bcfg2-server

> The wrong-line-in-lsb-tag is due to continuation of the Description
> fields. I'm not sure whether rpmlint is wrong, or the init
> file. subsys-not-used: I wouldn't had marked it as and error in
> rpmlint, but maybe it's not a bad idea to add it to the init file.

According to this:

http://www.freestandards.org/spec/booksets/LSB-Core-generic/LSB-Core-generic/initscrcomconv.html

the continuation of the Description field should be OK, so it looks
like a bug in rpmlint.

> E: bcfg2 subsys-not-used /etc/rc.d/init.d/bcfg2

The bcfg2 init script is a one-shot script - it doesn't actually start
a server in the background so creating a file in /var/lock/subsys
doesn't make sense.

> E: bcfg2-server subsys-not-used /etc/rc.d/init.d/bcfg2-server

Fixed in the next release.

> rpm install is noisy, the openssl output should go to /dev/null. You
> need to reverse the order of 2>&1 and /dev/null.

Turns out that runing openssh in %post to generate a key is not
needed.  The bcfg2-admin script will take care of generating the key.

> The file /etc/bcfg2.key is unowned. That's like for openssh's keys,
> but perhaps not the best practice. Better own a dummy file, mark it
> as %config(noreplace), and overwrite it on first install. The key
> would remain in the rpmdb as a changed config file, so upgrades
> would not touch it and uninstalls would keep it as *.rpmsave. This
> is just a (very) weak suggestion, though.

/etc/bcfg2.key should be marked %ghost and %config(noreplace)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.