[Bug 220210] Review Request: krename - Powerful batch file renamer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: krename - Powerful batch file renamer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220210





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-21 08:37 EST -------
First review of this package.

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* BuildRequires
-----------------------------------------------------------
Requires:       hicolor-icon-theme
-----------------------------------------------------------
  - Usually this is regarded as "not needed to be written"
    because hicolor-icon-theme is generally considered as
    a type of rpms like "filesystem" and many GUI packages
    depend on this package directly/indirectly.

* Documentation
  The following documentations include non-UTF8 characters.
  Consider them to UTF-8 characters.
-----------------------------------------------------------
/usr/share/doc/krename-3.0.13/ChangeLog:  ISO-8859 English text
/usr/share/doc/krename-3.0.13/TODO:       Non-ISO extended-ASCII English text,
with very long lines
-----------------------------------------------------------

* Desktop files
-----------------------------------------------------------
Categories=Application;Utility;Qt;KDE;
-----------------------------------------------------------
  Category "Application" is deprecated and so this should
  be removed.
-----------------------------------------------------------
[tasaka1 at dhcp158 krename]$ desktop-file-validate
/usr/share/applications/fedora-krename.desktop 
/usr/share/applications/fedora-krename.desktop: warning: The 'Application'
category is not defined by the desktop entry specification.  Please use one of
"AudioVideo", "Audio", "Video", "Development", "Education", "Game", "Graphics",
"Network", "Office", "Settings", "System", "Utility" instead
-----------------------------------------------------------

* Scriptlets requirements
-----------------------------------------------------------
%{_datadir}/icons/hicolor/*/apps/%{name}.png
-----------------------------------------------------------  
  This requires updating of GTK+ icon cache (desribed in the following).

  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

  Actually I cannot see icons on KRename menu entry.

* File and Directory Ownership
  - On my system, the following directories are not owned by
    any packages.
------------------------------------------------------------
/usr/share/apps/konqueror/
/usr/share/apps/konqueror/servicemenus/
------------------------------------------------------------
    ... because I am a GNOME user and I don't have kdebase
    installed. I think this package should own these
    directories as this package can be used for non-KDE users,
    too.

B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   (= this is okay, except for things written in A)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.