[Bug 189195] Review Request: horde - php application framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: horde - php application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195





------- Additional Comments From fedora at theholbrooks.org  2006-12-21 16:31 EST -------
Spec URL: http://theholbrooks.org/RPMS/horde.spec
SRPM URL: http://theholbrooks.org/RPMS/horde-3.1.3-9.src.rpm

I've gone ahead and rebased registry.php to 1.255.2.17 (the version that ships
with 3.1.3), but there were only 2 differences (lines 53 and 55) when
calculating $webroot.  All the other diff entries you saw involving $fileroot
are intentional and required.  By default, registry.php assumes that it is
living in "$webroot/config/", so it assigns fileroot to be './../appname' which
normally resolves to "$webroot/appname/" and the world keeps on turning. 
However, since our registry.php lives in /etc/horde/, './../appname' resolves to
'/etc/appname' which doesn't exist let alone contain web content, so horde dies.

To fix this issue, I created the $fileroot variable that statically contains
'/usr/share/horde', and then manually tweak all the application-specific
sections to reference $fileroot instead of __FILE__.  Since I agree it's not
very clear this is intentional, I've renamed $fileroot to a constant:
FEDORA_FILEROOT, to make it obvious this is an intentional distro-specific tweak.

I also added a bit about localhost in the README

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.