[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





------- Additional Comments From jspaleta at gmail.com  2006-12-22 23:32 EST -------
It looks good. Here is the formal review.
I'm going to start a clock on this, and if noone brings up any blockers I'll
approve tomorrow evening.

-jef

GOOD:
*Built in mock on i386 against fedora-development
*rpmlint runs cleanly against it
*follows naming guidelines
*licnese is LGPL and spec tag matches
*COPYING file in %doc
*spec in US/english and legible
*Include source matches upstream md5sum
52c0b48905f11cac71df1f8560c8f4d7  telepathy-stream-engine-0.3.18.tar.gz

*buildrequires look good
*no locales to worry about
*no shared libraries
*not relocatable
*does not create any unowned directories. Package requires   
  libdbus-1.so.3 which is provided by dbus which owns 
  %{_datadir}/dbus-1/services/
*no duplicates in %files
*file permissions seem fine
*install and clean sections look good
*macro use is consistent
*docs is good
*no -devel subpackage
*no la files
*not a gui, no desktop file needed
*appears to meet all packaging guidelines



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.