[Bug 167147] Review Request: Aqsis - 3D Rendering system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-23 04:41 EST -------
Well, would you provide both spec/srpm of this package
for convenience? Also, each you modify spec/srpm, you must
change (increment) release number because only changing
srpm/spec without release number confuses people who
check it.

Only from I viewed the spec file in comment #25 (I have not
tried to rebuild this, please provide srpm),
* Don't write redundant Requires which are required automatically
  by libraries' dependencies.
* Don't write redundant BuildRequires which are included in
  minimal. Check:
  http://fedoraproject.org/wiki/Extras/FullExceptionList

* Please explain why -devel package should include static 
  archives
  Check "Exclusion of Static Libraries" of
  http://fedoraproject.org/wiki/Packaging/Guidelines
--------------------------------------------
%{_libdir}/%{name}/*.a
--------------------------------------------

* 
--------------------------------------------
%{_bindir}/mpanalyse.py
%exclude %{_bindir}/mpanalyse.pyo
%exclude %{_bindir}/mpanalyse.pyc
--------------------------------------------
  Would you consider to rename this python script to mpanalyse?
  Generally, putting a script named *.py is regarded to be avioded.
  Unnecessary Byte compilation of
  http://fedoraproject.org/wiki/Packaging/Python

* Requires:	%{name} = %{version}
  Why not require release dependency? 
-----------------------------------------------------------
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} -----------------------------------------------------------
  from http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* %config %{_sysconfdir}/aqsisrc
  Please explain why this is not marked as %config(noreplace).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.