[Bug 167147] Review Request: Aqsis - 3D Rendering system

Sat Dec 23 17:40:58 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147

------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-23 12:40 EST -------
(In reply to comment #27)
> >>  Please explain why -devel package should include static archives
> We want to deliver two useful developer libraries, libri2rib, and libslxargs.
Well, I rebuilt this, however I cannot understand what you want
to do...
Build log says that all files used in these archives are included
in libaqsis.so.1, so including libaqsis.so in -devel package 
should be enough.
And.... including _static_ archive into _shared_ dynamic library is
wrong because rpmlint complains:
----------------------------------------------------
E: aqsis shlib-with-non-pic-code /usr/lib/libaqsis.so.1.2

shlib-with-non-pic-code :
The listed shared libraries contain object code that was compiled
without -fPIC. All object code in shared libraries should be
recompiled separately from the static libraries with the -fPIC option.
----------------------------------------------------
.. You should
* compile all files used in libaqsis.so.1.2 with -fPIC. libaqsis.so.1.2
  uses compiled objects in static archives without -fPIC used, which
  is wrong.
* After it is modified so as all files used in libaqsis.so.1.2
  are compiled with -fPIC, providing static archives should not be
  necessary as all files are included in libaqsis.so.1.2.

> Both rely on libaqsistypes, if 
> we deliver them both with libaqsistypes embedded, there will 
> be clashes if anyone wants to use both of 
> them, 
  This should be fixed when libaqsis compilation is fixed.  

> >>  Would you consider to rename this python script to mpanalyse?
> I could do it, but I'd prefere to leave it a .py because 
> it would be in line with other platforms we support 
> and it showes the user that it is a python script.
  IMO that "it showes the user that it is a python script" is not
  a enough reason. Many (in my environment, almost all) python
  scripts in /usr/bin has a name without .py suffix.
  Generally,
  * Executables used in users directly (which are under normal path)
    should not have suffix as possible.
  * If a executable is normally considered to be used from other
    executables and not to be used directly by user, the executable
    may have a suffix like .py or .sh, however, generally it should
    not under normal path and should be under %{_libexecdir}.
    (For second one, check "Filesystem Layout" of
     http://fedoraproject.org/wiki/Packaging/Guidelines).

   IMO, if no special reason exists, the filename should be renamed
   also on other platforms (however, I don't care about them).

==================================================================
And.. aqsis related packages make lots of rpmlint complaint.

------------------------------------------------------------------
1. E: aqsis shlib-with-non-pic-code /usr/lib/libaqsis.so.1.2
2. W: aqsis conffile-without-noreplace-flag /etc/aqsisrc
3. E: aqsis invalid-spec-name aqsis.fedora.spec
4. W: aqsis rpm-buildroot-usage %build scons %{?_smp_mflags}
destdir=$RPM_BUILD_ROOT \
5. W: aqsis mixed-use-of-spaces-and-tabs (spaces: line 89, tab: line 6)
6. E: aqsis-data summary-too-long Example content for the open source
RenderMan-compliant Aqsis 3D rendering solution
7. W: aqsis-data no-documentation
8. E: aqsis-data non-executable-script
/usr/share/aqsis/content/ribs/features/layeredshaders/render.sh 0644
9. E: aqsis-data non-executable-script
/usr/share/aqsis/content/ribs/scenes/vase/render.sh 0644
10. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/shadercompiler/slparse/scanner.ll
11. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/texturing/plugins/png2tif/png2tif.c
12. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/displays/d_sdcBMP/d_sdcBMP.cpp
13. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/implicit.h
14. E: aqsis-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/implicit.h
15. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/dbo_plane.c
16. E: aqsis-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/dbo_plane.c
17. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/pool.h
18. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/displays/d_exr/dspyhlpr.c
19. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/noise1234.cpp
20. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/noise1234.h
21. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/rib/rib2/scanner.ll
22. E: aqsis-devel summary-too-long Development files for the open source
RenderMan-compliant Aqsis 3D rendering solution
23. W: aqsis-devel no-documentation
-----------------------------------------------------------------------
Well,
-----------------------------------------------------------------------
1. As said above, /usr/lib/libaqsis.so.1.2 uses object files without 
   -fPIC used on compilation.
2. For now, I leave at it is.
3. The name of spec file must be aqsis.spec
4. Usually using $RPM_BUILD_ROOT in build stage is wrong because this 
   frequently causes wrong results in "real" install. Consider if
   this description (i.e. using $RPM_BUILD_ROOT) can be moved at
   %install stage.
5. For indentation, you should use tabs or spaces, not both, for
   cosmetic issue.
6,22 The "Summary:" must not exceed 79 characters.
7,23 This can be ignored.
8,9 Shell scripts with shebang should have executable permissons.
    If the shell scripts should not have executable permissions,
    then shebangs should be removed.
10-21: These usually means:
    A. source code should not have executable permissions.
    B. A file with Windows-like end-of-line encodings should be fixed
       so as to have Unix end-of-line encoding.

I have not checked these packages by installing them because I think
there is a lot of things to be fixed before doing so....

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.