[Bug 220743] Review Request: postgis - Geographic Information Systems Extensions to PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgis - Geographic Information Systems Extensions to PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220743


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ruben at rubenkerkhof.com




------- Additional Comments From ruben at rubenkerkhof.com  2006-12-26 07:36 EST -------
Review for release 1:
* RPM name is OK
* Source postgis-1.2.0.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of postgis-utils looks OK
* rpmlint of postgis-jdbc looks OK
* rpmlint of postgis looks OK
* File list of postgis-utils looks OK
* File list of postgis-jdbc looks OK
* File list of postgis looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

Minor:
* Duplicate BuildRequires: jpackage-utils (by ant), ant (by ant-junit), junit (by ant-junit)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.