[Bug 219978] Review Request: thunar-media-tags-plugin - Media Tags plugin for the Thunar file manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thunar-media-tags-plugin - Media Tags plugin for the Thunar file manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219978


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-12-26 21:13 EST -------

See below - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License(GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
1535da390f7e26350e9bff1a5bc3cdae  thunar-media-tags-plugin-0.1.1.tar.bz2
1535da390f7e26350e9bff1a5bc3cdae  thunar-media-tags-plugin-0.1.1.tar.bz2.1
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
i386/x86_64 - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Should the name of this package have a capital T ?
ie,

thunar-media-tags-plugin

should be

Thunar-media-tags-plugin

Since the Thunar package uses a uppercase T?

Otherwise I see no blockers or issues, so this package is
APPROVED. If you do decide to change it to use a uppercase T, also do
change the summary of this bug so the package is tracked properly.

Don't forget to close this package review NEXTRELEASE once it's been
imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.