[Bug 189195] Review Request: horde - php application framework

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 27 22:38:42 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: horde - php application framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195





------- Additional Comments From fedora at theholbrooks.org  2006-12-27 17:38 EST -------
Spec URL: http://theholbrooks.org/RPMS/horde.spec
SRPM URL: http://theholbrooks.org/RPMS/horde-3.1.3-10.src.rpm

* Wed Dec 27 2006 Brandon Holbrook <fedora at theholbrooks.org> 3.1.3-10
- Remove execute permission from all php scripts under horde/lib/
- Make /usr/share/horde/config/ symlink relative
- Don't echo anything in %%post

Thanks, Jason.  I've addressed your blockers in this next RPM.  All the php
files under horde/lib/ are just class definitions and aren't supposed to be
executed.  upstream must have let that slip by.  I put a find section in prep to
clear these bits.  I also made the config symlink relative.

WRT output in %post, I've been keeping my eye on the thread in the list with
interest, knowing that I output in this package.  The only issue I have is that
this (and some of my other) packages don't work "out of the box", but first
require per-site configuration.  Coupled with this is the fact that
/usr/share/doc is almost unheard of outside of our die-hard linux users circle,
and even less so that some packages create a README.Fedora file targeted
specifically at users for post-install instructions.  We need to find a way to
better educate our userbase about /usr/share/doc and README.Fedora files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list