[Bug 200630] Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 28 22:35:34 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200630





------- Additional Comments From toshio at tiki-lounge.com  2006-12-28 17:35 EST -------
Previous patch is untested.  It uses Term::ReadKey to prompt for a password if
the user specifies --password on the commandline.

You'll need to add a BuildRequires for perl(Term::ReadKey).  Not sure if rpm
will pick up the matching Requires: automatically as I haven't tested this.

The spec file is now picking up duplicate files in the %files section:
  %{_datadir}/pgsql/%{name}
  %{_datadir}/pgsql/%{name}/*.tmpl

You should only have the first of those two lines as rpm will find files inside
the directory recursively.

I'd say the next step is to see if the patch I proposed works for you, see if
upstream is amenable to including it, and then release an rpm with it included.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list