[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 28 23:17:32 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geany - a lightweight gtk2 based IDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922





------- Additional Comments From dakingun at gmail.com  2006-12-28 18:17 EST -------
Seems you're a new contributor, so you'll need a sponsor. In the meantime, here
are a couple of things (not exhaustive) that needs to be fixed with the spec file;

1. Your package includes a .desktop file, and that needs to be properly install
with desktop-file-install, and include a Buildrequire on desktop-file-utils.
2. Locales needs to be installed using the %find_lang macro.
3. You also likely need another BR on gettext (because of the locales).

Also the Requires on glib, gtk, and pango are not necessary, they are
automatically pulled in by rpm.
I've attached a patch to your spec file that fix these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list