[Bug 220796] Review Request: turba - horde contact manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: turba - horde contact manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220796


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-12-28 21:10 EST -------
First off, I think the License: tag is wrong.  It's certainly not GPL; the
Horde site lists it as "Apache-like".  In truth it is essentially the Apache
license, version 1.0, with some strings changed and the "some parts are public
domain" bit removed from the end.  It is obviously free.  It's also kind of
dumb; how can you distribute a bunch of scripts in binary form?

But in any case, can you change the license tag to "Apache Software License
v1"?  I see nothing else problematic with this package, so you can go ahead
and fix it when you check in.

Also, I note that a Perl dependency snuck in.  I don't suppose this hurts
anything, although the single script that uses it is not terribly useful.

As usual, I'll start with rpmlint, but these are getting repetetive so I'll
just post a summary.

E: turba htaccess-file /usr/share/horde/turba/lib/.htaccess
   And four more.  All are acceptable; these htaccess files are needed.

E: turba non-readable /etc/horde/turba/attributes.php 0660
   And ten more.
E: turba non-standard-dir-perm /etc/horde/turba 0770
   These are all necessary for security.

E: turba non-standard-gid /etc/horde/turba apache
   And twenty-three more.
   These are all necessary for security.

W: turba conffile-without-noreplace-flag /etc/horde/turba/attributes.php.dist
   And five more.
   These are distributed config files, and should not be marked %noreplace.

Review:
* source files match upstream:
   a0407717f3f64fb33f6a57e2244a12b4  turba-h3-2.1.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only acceptable complaints.
* final provides and requires are sane:
   config(turba) = 2.1.3-2.fc7
   turba = 2.1.3-2.fc7
=
   /bin/sh
   /usr/bin/perl
   /usr/bin/php
   config(turba) = 2.1.3-2.fc7
   horde >= 3
   perl(Getopt::Std)
   php >= 4.3.0
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* locales are handled properly
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, provided you change the License: tag appropriately.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.