[Bug 220919] Review Request: kronolith - The Horde calendar application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kronolith - The Horde calendar application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220919


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-12-29 21:11 EST -------
I needed to remove "tarballs/" from the Source URL in order to grab the
tarball.  Other than that, this package is fine so you can fix it when you check in.

As with the other horde-using packages, these rpmlint warnings are expected
and necessary:
E: kronolith htaccess-file /usr/share/horde/kronolith/scripts/.htaccess
E: kronolith non-readable /etc/horde/kronolith/conf.xml 0660
  [six more]
E: kronolith non-standard-dir-perm /etc/horde/kronolith 0770
E: kronolith non-standard-gid /etc/horde/kronolith apache
  [seven more]
E: kronolith non-standard-uid /etc/horde/kronolith apache
  [seven more]
W: kronolith conffile-without-noreplace-flag /etc/horde/kronolith/conf.xml
  [three more]

Review:
* source files match upstream:
   df6d6fc99012865b18b089212c7544ad  kronolith-h3-2.1.4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only ignoreable complaints.
* final provides and requires are sane:
   config(kronolith) = 2.1.4-1.fc7
   kronolith = 2.1.4-1.fc7
  =
   /usr/bin/php
   config(kronolith) = 2.1.4-1.fc7
   horde >= 3
   php >= 4.3.0
* %check is not present; no test suite upstream.  Basic manual testing shows
  things work OK
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* locales are handled properly.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.