[Bug 220789] Review Request: fail2ban - Ban IPs that make too many password failures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fail2ban - Ban IPs that make too many password failures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220789





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-30 03:10 EST -------
Well:

* Would you explain why you think that condrestart treatment of the
  service on %postun stage is unneeded?
* I still does not like the appearance of the start/exit of fai2ban service.
  Currently:
--------------------------------------------
[root at localhost ~]# service fail2ban start
Starting fail2ban: 
[root at localhost ~]# service fail2ban stop 
Stopping fail2ban: 
--------------------------------------------
  This should be like:
--------------------------------------------
[root at localhost ~]# service sshd start
Starting sshd:                              [ OK ]
[root at localhost ~]# service sshd stop 
Stopping sshd:                              [ OK ]
--------------------------------------------
* And.. 
--------------------------------------------
[ "${NETWORKING}" = "no" ] && exit 0
[ -f /etc/fail2ban.conf ] || exit 0
---------------------------------------------
  should be "exit 1" or something else: exit code 0 is
  wrong IMO. Also some messages which tells why starting
  fail2ban failed should be printed out.

* Still I think (strongly) that /usr/bin/fail2ban should 
  be moved under
  /usr/sbin because this is a sysadmin tool
  ... and /etc/fail2ban.conf should be /etc/sysconfig/fail2ban .

* And I think this package should own /var/log/fail2ban

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.