[Bug 219972] Review Request: poker-network - A poker server, client and abstract user interface library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: poker-network - A poker server, client and abstract user interface library
Alias: poker-network

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219972





------- Additional Comments From chris.stone at gmail.com  2006-12-31 13:42 EST -------
(In reply to comment #7)
> builds in mock in fc6 and devel on x86.
> I'm going through this now, doing a detailed review.
> 
> PROBLEM #1:
> poker2d desktopfile has the EXEC in the wrong location.
> should be EXEC=%{_exec_prefix}/games/poker2d
> because %{_exec_prefix}/games/poker2d

Fixed this.

> 
> because /usr/games is not in the standard executable path.
> 
> PROBLEM #2:
> On my fc-6 system gnome seems to be unable to recognize that poker2D.xpm is
> there. Even if I create a custom panel launcher and attemnpt to select the
> poker2D.xpm from the pixmap directory in the icon chooser interface, it throws
> an icon 'poker at D' not found error dialog. Do we have to do somethng silly and
> convert this to png?   

I asked in #fedora-packaging about icons placed in pixmap directory, and this is
the reply:

15:27:20       XulChris | if upstream installs in icon in %{_datadir}/pixmaps/
should it be moved to %{_datadir}/icons/ instead and run gtk-update-icon-cache?
           15:28:02       XulChris | or should it just be left in pixmaps/ w/o
running gtk-update-icon-cache?                                                 
                      17:49:19             ---| User: *** rdieter_away is now
known as rdieter1
18:05:45       rdieter1 |  XulChris: imo, move it, yadda, and ping upstream to
do the same.

So perhaps moving the icon to the icons/ directory will fix it in GNOME? Not
sure since I run KDE, I will try moving the icons in the spec let me know if it
fixes it in GNOME.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.