[Bug 193531] Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193531





------- Additional Comments From paul at city-fan.org  2006-07-02 09:01 EST -------
(In reply to comment #12)
> But however, mock failed on i386
> make[1]: *** [basepcbframe.o] Error 1
> make[1]: Target `all' not remade because of errors.
> make[1]: Leaving directory `/builddir/build/BUILD/kicad-dev/gerbview'
> make: *** [all] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.20325 (%build)

Is there nothing further up the log showing what the problem with basepcbframe.o
was?

> and you need not to own the following directories
> %dir %{_libdir}/%{name}
> %dir %{_datadir}/%{name}
> %dir %{_docdir}/%{name}/

The files list contains:

%dir %{_libdir}/%{name}
%{_libdir}/%{name}/plugins/*
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
%dir %{_docdir}/%{name}/
%{_docdir}/%{name}/*

This could possibly be simplified to:

%{_libdir}/%{name}/
%{_datadir}/%{name}/
%{_docdir}/%{name}/

Some people prefer to own directories explicitly though. No harm in that.

The only issue I see what what's currently there is that directory
%{_libdir}/%{name}/plugins needs to be owned by this package.

> use %{name} instead of kicad as much as you can

That already seems to be the case, and again that's just a maintainer preference
and not something that *needs* to be changed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.