[Bug 192311] Review Request: cobbler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cobbler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311





------- Additional Comments From paul at city-fan.org  2006-07-05 13:03 EST -------
(In reply to comment #7)
> Don't bother with defining your own macros for name, version, and release, rpm
> does that.
> 
> -- If I remove the version macro, 'version' will be seperately hard coded into 3
> parts of the file.  Having the version macro at the top of the file is most
> convient for editing and is very much D.R.Y.  If i need to call it something
> other than 'version', this can be done, though I need to understand the
> technical reason for this.

If you remove the line:
%define version 0.1.0

And replace:
Version: %{version}
with:
Version: 0.1.0

then rpm will define the %{version} macro for you, which you can use in the rest
of the spec file just as you are now. Defining it manually is simply redundant.

Same goes for the %{name} and %{release} macros; there is no need to define them
manually.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.