[Bug 197304] Review Request: perl-WWW-Myspace
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jul 5 22:03:16 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-WWW-Myspace
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197304
------- Additional Comments From tibbs at math.uh.edu 2006-07-05 17:54 EST -------
I added perl-Locale-SubCountry to my local repo to test this.
It looks like RPM bugs strike again; there are no manual dependencies in this
package (save the MODULE_COMPAT thing) but RPM somehow extracts these:
perl(WWW::Myspace)
perl(WWW::Myspace) >= 0.21
which will probably need to be filtered.
Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* source files match upstream:
655665da1b696e4b7d30989d623356e9 WWW-Myspace-0.49.tar.gz
* latest version is being packaged.
O BuildRequires are proper (redundant BR: perl not a blocker)
* package builds in mock (development, x86_64) with one local package.
* rpmlint is silent.
X final provides and requires are sane:
perl(WWW::Myspace) = 0.49
perl(WWW::Myspace::Comment) = 0.15
perl(WWW::Myspace::Data) = 0.05
perl(WWW::Myspace::FriendAdder) = 0.08
perl(WWW::Myspace::FriendChanges) = 0.03
perl(WWW::Myspace::Message) = 0.13
perl(WWW::Myspace::MyBase) = 0.3
perl-WWW-Myspace = 0.49-0.fc6
=
/usr/bin/perl
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(Class::DBI)
perl(Class::DBI::AbstractSearch)
perl(Class::DBI::Loader)
perl(Config::General)
perl(Contextual::Return)
perl(Data::Dumper)
perl(DateTime)
perl(File::Spec::Functions)
perl(IO::Prompt)
perl(List::Compare)
perl(Locale::SubCountry)
perl(Math::Round)
perl(Params::Validate)
perl(Scalar::Util)
perl(Spiffy)
perl(WWW::Mechanize)
X perl(WWW::Myspace)
X perl(WWW::Myspace) >= 0.21
perl(WWW::Myspace::Comment)
perl(WWW::Myspace::Data)
perl(WWW::Myspace::FriendAdder)
perl(WWW::Myspace::Message) >= 0.08
perl(WWW::Myspace::MyBase)
perl(YAML)
perl(strict)
perl(warnings)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present but necessarily disabled.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list