[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-07 07:30 EST -------
(In reply to comment #9)
> rpmlint warnings:
> 
> W: ogre-devel no-documentation
>    - Can be safely ignored since docs are in a -doc subpackage.
> 
> E: ogre-devel invalid-soname /usr/lib64/libOgrePlatform.so libOgrePlatform.so
>    - Not sure where this is coming from.

Oops, I meant to fix that one but never got around to fixing it, rpmlint is
unhappy because that is an unversioned .so directly under libdir. Since this lib
actually gets dlopened by libOgreMain I've moved it to libdir/OGRE

> MUSTFIX
> =======
> * The 'tr' trick in Source0: is cute, but my preference is to limit
>   macro substitutions in Source0 to simple %{name} and %{version} only.
>   Anything more complicated (like spawning subshells) becomes
>   harder to read.  In this case, just hard code the version string.

Erm, shouldn't that be a should fix. Nowhere in the guidelines it says use of
macros etc is forbbiden in Source0. I know some people want to copy and paste
the Source0 URL to wget, some people even want it to contain 0 macro's. I say
those people should learn to use "spectool -g name.spec" which will do the macro
expansion and cut and pasting for them, directly calling wget. -> EWONTFIX

> * -devel subpackage should use full version in base package dependency (it
>   is missing -%{release}), or add a comment why it's not needed:
>   Requires: %{name} = %{version}-%{release}
Fixed

> * BR: flex, bison seem to be unnecessary.
./configure was checking for them but indeed it builds fine without, removed.

New version is here:
* Fri Jul  7 2006 Hans de Goede <j.w.r.degoede at hhs.nl> 1.2.1-2
- Make -devel package Requires on the main package fully versioned.
- Move libOgrePlatform.so out of %%{_libdir} and into the OGRE plugins dirs as
  its not versioned and only used through dlopen, so its effectivly a plugin.

Spec URL: http://people.atrpms.net/~hdegoede/ogre.spec
SRPM URL: http://people.atrpms.net/~hdegoede/ogre-1.2.1-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.