[Bug 197198] Review Request: ntop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198





------- Additional Comments From pertusus at free.fr  2006-07-07 11:38 EST -------
(In reply to comment #30)
> (In reply to comment #29)

> Ok, I will remove the plugins dangling in the /usr/lib directory. 

I was speaking about the /usr/lib/ntop/plugins/ directory: every
file in this directory ending in .so is loaded.

> > And there is also another error, but it may only happen on the first run
> > **ERROR** LASTSEEN: Unable to open LsWatch database (/var/ntop/LsWatch.db)- the
> > plugin will be disabled
> 
> Did you test to see if it re-occurs ? The file is present on my system. 

It re-occured. I guess I know why, since for an unknown reason most
of the files in  /var/ntop/ belong to root, although I never started
ntop with -u root. Maybe this comes from the kills of ntop while it
asked for a password?


> myrrd is indeed an older rrdtool, however, according to Luca, it has been
> modified enough to warrant using it instead of the system provided rrdtool. I
> will leave it with myrrd.

Ok. But at least put a comment in the spec file. And you'll have to
watch out the rrdtool updates, especially the security issues...

> I have disabled the version check in the init script. 

It is still used during the required first run that sets the password.
I think it shouldn't.

> A control-C does shut down ntop here. Its not instant, it performs a graceful
> shutdown. 

Not when ntop is asking for a password. At least seems so to me. I'll
retest with the next srpm.

(and I get that with ntop -t 4 interrupted by control-C:

ven 07 jui 2006 17:37:06 CEST  RRD: Thanks for using the rrdPlugin
ven 07 jui 2006 17:37:06 CEST  RRD: Done
ven 07 jui 2006 17:37:06 CEST  CLEANUP: Freeing device eth0 (idx=0)
*** glibc detected *** ntop: free(): invalid next size (normal): 0x0962c2d8 ***
======= Backtrace: =========
/lib/libc.so.6[0x1fec88]
/lib/libc.so.6(__libc_free+0x78)[0x20216f]
/usr/lib/libntop-3.2.so(ntop_safefree+0x2c)[0x935d4c]
/usr/lib/libntop-3.2.so(cleanup+0xf13)[0x937953]
[0xb7f08420]
/usr/lib/libntop-3.2.so(_ntopSleepWhileSameState+0x2f)[0x95b09f]
ntop[0x804b12f]
/lib/libc.so.6(__libc_start_main+0xdc)[0x1b0794]
ntop[0x8049d31]
======= Memory map: ========
Abandon
) 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.