[Bug 197744] Review Request: perl-DateTime-Event-ICal

bugzilla at redhat.com bugzilla at redhat.com
Sat Jul 8 03:00:20 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Event-ICal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197744


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-07-07 22:51 EST -------
* source files match upstream:
   a68e58f5aac48a739249118d078e9947  DateTime-Event-ICal-0.09.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64, some dependencies added to local
repo)
* rpmlint is silent.
* noarch package, so no debuginfo.
* final provides and requires are sane:
   perl(DateTime::Event::ICal) = 0.09
   perl-DateTime-Event-ICal = 0.09-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(DateTime)
   perl(DateTime::Event::Recurrence) >= 0.11
   perl(DateTime::Set)
   perl(DateTime::Span)
   perl(DateTime::SpanSet)
   perl(Exporter)
   perl(Params::Validate)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=6, Tests=68, 111 wallclock secs (110.89 cusr +  0.23 csys = 111.12 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list