[Bug 189482] Review Request: pcb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189482





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-09 16:21 EST -------
(In reply to comment #13)
> Does this mean that I am the _official_ packager of pcb now ?
> 

I guess it does, there is no official procedure for this, but packages have been
taken over while in review like tihs before.

> SPEC : http://beta.glwb.info/pcb/pcb.spec
> SRPM : http://beta.glwb.info/pcb/pcb-0.20060422-2.src.rpm
> 
> %changelog
> - fixed E: pcb info-dir-file /usr/share/info/dir
> - added /sbin/install-info as requires for %%post and %%preun
> - added icon and treated GTK+ icon cache as required
> 
> I was not quite sure how to deal with the icon, so i put it in %post.
Erm, thats wrong, really wrong, on other peoples systems %{SOURCE2} won't even
be available the commented line at the end of %install is how it should be done,
you probably need to put a:
mkdir -p $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps
above that line to make it to work.

Once the icon installation is ok (and completly removed from %post) the package
is ok and I'll approve it.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.