[Bug 191208] Review Request: The Ipe extensible drawing editor

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 9 22:28:08 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: The Ipe extensible drawing editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208





------- Additional Comments From laurent.rineau__fedora_extras at normalesup.org  2006-07-09 18:19 EST -------
(In reply to comment #6)
> 
> MUST:
> * ipe-doc must depend on ipe
> 
> please deal with MUST, then import the package
> 
> APPROVED

Thank you for your review! I have commited release 6.0-0.7.pre26:

* Tue Jul  4 2006 Laurent Rineau 
<laurent.rineau__fedora_extras at normalesup.org> - 6.0-0.7.pre26
- In %%files, use libipe.so.1*, instead of libipe.so.*
- Make sub-package %%{name}-doc depend on %%{name}

* Wed Jun 28 2006 Laurent Rineau 
<laurent.rineau__fedora_extras at normalesup.org> - 6.0-0.6.pre26
- Added a patch, ipe_6.0pre26-initui.cpp.patch, to fix temporarely an upstream 
bug: QMenu aboutToshow() signal has a lowercase "a".

> SHOULD:
> * there is no icon for the .desktop file, add one later, if available

The upstream tarball has no icon. Who should create one. Me?!

> * the documentation is in /usr/share/ipe/6.0/doc; if it is not
>   too much work, move it to /usr/share/doc/ipe-doc-6.0

Well, I do not know how to install things into /usr/share/doc/ipe-doc-6.0, 
because the %doc macro of the -doc subpackage begins with:
  rm -rf %{_buildroot}/usr/share/doc/ipe-doc-6.0
which remove all files installed here during %install

> * if the doc package is not installed, the web browser will report an error,
>   if help is invoked in ipe; I don't consider this a blocker, but should
>   probably dealt with somehow

Maybe I should merge the doc package with the main package. Or trick a 
IPEBROWSER script that checks the presence of the documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list