[Bug 195363] Review Request: esc and esc-xulrunner-devel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





------- Additional Comments From rstrode at redhat.com  2006-07-10 14:09 EST -------
A couple of comments.

We upstream ESC, yes?  Can we make the tarball .tar.bz2 or .tar.gz instead of
.tgz ?  It's more consistent that way.  Also, why don't we ship the shell script
and desktop file in the upstream tarball?

I've noticed in the %install section you are manually copying over files.  Does
the makefile have a working install target?  The usual procedure is

make install DESTDIR=$RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.