[Bug 194276] Review Request: kdeaccessibility: KDE accessibility tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeaccessibility: KDE accessibility tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194276





------- Additional Comments From cgoorah at yahoo.com.au  2006-07-11 20:39 EST -------
1.
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kmag.desktop:
warning: file contains key "DocPath", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kmousetool.desktop:
warning: file contains key "DocPath", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kmouth.desktop:
warning: file contains key "DocPath", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"

Use the following to correct the shut-the-hell-up about KDE's use of DocPath:

for f in
$RPM_BUILD_ROOT%{_datadir}/applnk/Applications/{kmag,kmousetool,kmouth}.desktop
do
  %{__sed} -i -e 's/DocPath/X-DocPath/' $f
done



2.
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kcmkttsd.desktop:
warning: file contains key "Keywords", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kcmkttsd.desktop:
warning: file contains key "ServiceTypes", this key is currently reserved for
use within KDE, and should in the future KDE releases be prefixed by "X-"
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kcmkttsd.desktop:
warning: file contains key "DocPath", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"


you can use this before desktop-file-installs, to correct the shut-the-hell-up
about KDE's use of 'Keywords':

%{__sed} -i \
         -e 's/Keywords/X-Keywords/'         \
         -e 's/ServiceTypes/X-ServiceTypes/' \
         -e 's/DocPath/X-DocPath/'           \
         $RPM_BUILD_ROOT%{_datadir}/applications/kde/kcmkttsd.desktop



3.
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/ksayit.desktop:
warning: file contains key "DocPath", this key is currently reserved for use
within KDE, and should in the future KDE releases be prefixed by "X-"

Solution:

%{__sed} -i -e 's/DocPath/X-DocPath/'
$RPM_BUILD_ROOT%{_datadir}/applications/kde/ksayit.desktop

4.
/var/tmp/kdeaccessibility-3.5.3-2-root-chitlesh/usr/share/applications/kde/kttsmgr.desktop:
warning: non-standard key "MimeTypes" lacks the "X-" prefix


5.
Now the repetitive:

/var/tmp/kdeaccessibility-3.5.3-2.fc5-root-mockbuild/usr/share/applications/kde/kcmkttsd.desktop:
error: invalid characters in value of key "Keywords[ca]", keys of type string
may contain ASCII characters except control characters

have gone. yooohoo :)

I've updated the spec file, see attachment.

I've left W: kdeaccessibility mixed-use-of-spaces-and-tabs for you to correct :)

Post an updated SRPM, Rex, i'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.