[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

Fri Jul 14 02:28:19 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835

------- Additional Comments From chris.stone at gmail.com  2006-07-13 22:19 EST -------
-rpmlint output:
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZNK5Atlas9Exception4whatEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTIN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTVN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11streamBeginEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13streamMessageEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase9streamEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase10mapMapItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11mapListItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase10mapIntItemERKSsl
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase12mapFloatItemERKSsd
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13mapStringItemERKSsS3_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase6mapEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11listMapItemEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase12listListItemEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11listIntItemEl
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13listFloatItemEd
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase14listStringItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase7listEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTIN5Atlas7Message11DecoderBaseE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBaseC2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7ElementC1ERKS1_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBaseD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7Element5clearENS1_4TypeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7Encoder14mapElementItemERKSsRKNS0_7ElementE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7EncoderD1Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7ElementaSERKS1_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas6Codecs3XMLC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7EncoderC1ERNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas9ExceptionD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTIN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZNK5Atlas9Exception4whatEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTIN5Atlas6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTVN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZN5Atlas6BridgeD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZN5Atlas9ExceptionD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZTIN5Atlas9NegotiateE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZTIN5Atlas6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas9NegotiateD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6Codecs6PackedC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6Codecs4BachC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6Codecs3XMLC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6BridgeD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasCodecs-0.6.so.1.0.0
_ZTIN5Atlas5CodecE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasCodecs-0.6.so.1.0.0
_ZN5Atlas5CodecD2Ev

It looks like linking is not done proplerly, there are many undefined non-weak
symbols in the .so files.  These libraries need to be linked against libAtlas.so.

- package named according to package naming guidelines
  - package could be named atlascpp as upstream doesnt seem to mind

- spec file matches package %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
O license field does not match actual license
- license contained in %doc
- spec file written in American english
- spec file is legible
O Unable to download source pacakge:
wget http://dl.sourceforge.net/worldforge/Atlas-C++-0.6.0.tar.gz
--19:18:24--  http://dl.sourceforge.net/worldforge/Atlas-C++-0.6.0.tar.gz
           => `Atlas-C++-0.6.0.tar.gz'
Resolving localhost... 127.0.0.1
Connecting to localhost|127.0.0.1|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found
19:18:24 ERROR 404: Not Found.
- package successfully compiles and builds on x86_64 FC-5
- All build dependencies are in BuildRequires, but optional build dependencies
are not listed (zlib and/or libbz2)
- package does not contain locales
- package properly calls ldconfig in %post/%postun
- package is not relocatable
- package owns all directories it creates
- package does not contain duplicate files
- package sets proper permissions on files
- package contains proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- header files are contained in devel package
- pkgconfig files in devel package
- library files w/o suffix are in devel
- devel package requires base package
- package does not contain .la files
- package is not a GUI needing a .desktop file
- package does not own files or directories owned by other packages

=== MUST ===
- Add Requires: pkgconfig to devel package
- Comments say test fails on FC6, but infact it is failing on all x86_64 arches
because of an x86_64 warning.  Patch the code to not use -Werror so that checks
can be run
- Fix linking of all the .so files, they should be linked with -lAtlas and
libAtlas needs to be built first.
- Explain why you do not build with optional zlib or libbz2
- README indicates that this package requires socket streams such as skstream,
explain why this is not in the Requires
- Why are man pages in doc/man not installed?
- Should tutoral/ be installed?
- Fix license to match actual license
- Fix Source0 URL so that I can actually verify the upstream source is 0.6.0
actually out yet?
- Why name Atlas-C++ instead of atlascpp?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.