[Bug 193897] Review Request: mysql-connector-java - Official JDBC driver for MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897


green at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |green at redhat.com




------- Additional Comments From green at redhat.com  2006-07-13 23:32 EST -------
Some initial feedback....

rpmlint output is:
W: mysql-connector-java non-standard-group Development/Libraries/Java

We just use Development/Libraries in Fedora.  Perhaps there's an argument to be
made for Development/Libraries/Java, but let's use the standard for now.  I'll
send a note to fedora-devel 

W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/docs/README.txt
W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/README.txt
W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/EXCEPTIONS-CONNECTOR-J

Fix these with sed in the %prep section like so: 
%{__sed} -i 's/\r//' README.txt

The spec file includes:
# remove all binary libs
find . \( -name "*.jar" -o -name "*.class" \) | xargs -t rm -f

I would rather that we strip the .jar files from the tarball prior to packaging.
 This will ensure that we don't accidentally ship binaries sans sources or
binaries with unfriendly licensing - even if they only show up in the SRPM.


Can you explain this part of the spec file?..
Provides: mm.mysql
Obsoletes: mm.mysql




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.