[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmodelfile - library for accessing WorldForge model files
Alias: libmodelfile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830





------- Additional Comments From chris.stone at gmail.com  2006-07-14 02:58 EST -------
- rpmlint output:
W: libmodelfile-devel no-documentation

okay to ignore, I dont see any docs that should go in devel

- package named according to package naming guidelines
- spec filename matches base package %{name}
- package meets packaging guidelines
- license tag in spec file is open source compatible
- license matches upstream license
- licnese included in %doc
- spec file written in American english
- spec file is legible
- source matches upstream
53ded1963cc863d0fabba4f0fb4ef2db  libmodelfile-0.1.92.tar.gz
- package successfully compiles and builds on x86_64 FC-5
- All build dependencies listed in BuildRequires
- package does not contain locales
- package properly uses %post/%postun ldconfig
- package is not relocatable
- package owns all directories it creates
- package does not contain duplicate files
- file permissions are set properly
- package has proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- header files are in devel package
- pkgconfig files are in devel package
- libraries w/o suffix are in devel
- devel require base package
- package does not contain .la files
- package is not a GUI needing a .desktop file
- package does not own files or directories owned by other packages


==== MUST ====
- Add Requires: pkgconfig to devel package
- make check should have %{?_smp_mflags}
- Why are you using find to remove .la files?  Why not just specifically state
which ones you are removing?  And you dont BR findutils but you sholdnt anyway
because you shouldnt be using find.
- I could not get source package from Source URL, I had to use:
http://dl.sourceforge.net/sourceforge/worldforge/libmodelfile-0.1.92.tar.gz
(not sure why) But Source0 should be updated accordingly
- Summary contains "acessing" which is not an english word
- Why is group System Environment/Libraries instead of Development/Libraries?
- Have you tested this in FC4? If you plan to support FC4 please test,
BuildRequires might be different (might need xorg-x11-devel or something)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.