[Bug 196146] Review Request: mod_nss

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_nss


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196146





------- Additional Comments From rcritten at redhat.com  2006-07-14 15:53 EST -------
The spec and SRPM files are updated.

1. Bah, my mistake. I was experimenting with using the make install target and
accidentally left that in. Removed.

2. Ok, you've convinved me. I made a few minor changes though. When determining
if we need to generate a database we only need to check one of the files. They
do not stand alone but work together in concert, so if one is temporary it is
safe to assume they all are. I switched to checking key3.db since that is the
most important file.

I also modified the deletion install test. I'm using if [ "$1" -eq 0 ] which
from the RPM docs means "Remove last version of package". I tested it and it
seems to work ok for me.

3. Removed the extra lines. Must be a style thing.

4. Great news.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.